Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes an NSURLProtocol runtime warning for didReceiveResponse #193

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fixes an NSURLProtocol runtime warning for didReceiveResponse #193

merged 1 commit into from
Oct 10, 2023

Conversation

jszumski
Copy link
Contributor

@jszumski jszumski commented Oct 6, 2023

Work towards #186.

Fixes case where URLSession:dataTask:didReceiveResponse: could sometimes return without calling its completion handler:

API MISUSE: dataTask:didReceiveResponse:completionHandler: completion handler not called

@jszumski
Copy link
Contributor Author

jszumski commented Oct 6, 2023 •
edited
Loading

I can't reproduce this CI failure locally on Xcode 14.2 or 15.0.

Failing tests:
	MonitorTests.testSyncWaitForMonitoredRequestsDoesNotTimeout()

@jszumski jszumski force-pushed the nsurlprotocol-misuse-completionhandler branch from 8aa24ef to d71669f Compare October 6, 2023 16:54
@jszumski
Copy link
Contributor Author

jszumski commented Oct 6, 2023

Green now, presumably just a flake

@jszumski
Fixes case where URLSession:dataTask:didReceiveResponse: could some…
8d4795f 
…times return before calling its completion handler
@jszumski jszumski force-pushed the nsurlprotocol-misuse-completionhandler branch from d71669f to 8d4795f Compare October 10, 2023 13:49
@tcamin tcamin merged commit 44fc27a into Subito-it:master Oct 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcamin tcamin tcamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jszumski @tcamin